-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jans-cli-tui): asset issues #9441
Conversation
Signed-off-by: Mustafa Baser <mbaser@mail.com>
DryRun Security SummaryThe pull request updates the "Assets" plugin in the Jans CLI TUI application, improves error handling, and provides documentation for securely managing custom assets on the Janssen Server. Expand for full summarySummary: The code changes in this pull request focus on updating the "Assets" plugin in the Jans CLI TUI (Text-based User Interface) application and providing documentation for managing custom assets on the Janssen Server. The key changes include updating the display name column to show the file name, modifying the asset saving logic, and improving error handling. From an application security perspective, the changes do not appear to introduce any obvious security vulnerabilities, but it's important to ensure that proper input validation, error handling, and security best practices are followed throughout the application. Additionally, the documentation updates related to custom assets management on the Janssen Server highlight the importance of secure implementation, including proper access controls, input validation, and handling of sensitive information. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
|
|
|
* fix(jans-cli-tui): asset fileName Signed-off-by: Mustafa Baser <mbaser@mail.com> * fix(jans-cli-tui): don't ask file name when editing asset Signed-off-by: Mustafa Baser <mbaser@mail.com> * docs(jans-cli-tui): update assets docs Signed-off-by: Mustafa Baser <mbaser@mail.com> * fix(jans-cli-tui): allow re-upload asset when edtiting Signed-off-by: Mustafa Baser <mbaser@mail.com> * fix(jans-cli-tui): asset service Signed-off-by: Mustafa Baser <mbaser@mail.com> * fix(jans-cli-tui): focus if deletation error popup raises in asset Signed-off-by: Mustafa Baser <mbaser@mail.com> --------- Signed-off-by: Mustafa Baser <mbaser@mail.com> Former-commit-id: b6722b5
closes #9429
closes #9376