fix: update wrong clause

[jgomer2001]

Prepare

• Read PR guidelines
• Read license information

---

Description

Target issue

closes #9181

Implementation Details

---

Test and Document the changes

• Static code analysis has been run locally and issues have been fixed
• Relevant unit and integration tests have been added/updated
• Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

• I confirm that there is no impact on the docs due to the code changes in this PR.

[dryrunsecurity]

DryRun Security Summary

The pull request focuses on improving the Agama authentication flow in the Janssen Project application, including updating the extractAgamaFlow function, handling cases where the userId is not present, and following good security practices such as encrypting the inum and using the AuthenticationService to authenticate users.

Expand for full summary

Summary:

The changes in this pull request appear to be focused on improving the Agama authentication flow in the Janssen Project application. The key changes include:

1. Updating the extractAgamaFlow function to correctly identify the Agama flow based on the acr parameter.
2. Handling the case where the userId is not present in the flow result, ensuring that the code does not attempt to authenticate the user in this scenario.

From a security perspective, the code seems to be well-designed and follows good security practices, such as:

1. Encrypting the inum (internal user number) before storing it in the session data.
2. Implementing checks to ensure that there is a single matching user based on the finish_userid_db_attr attribute, and setting an error message if there are multiple matches or no matches.
3. Using the AuthenticationService to authenticate the user by their inum, which is a standard and secure way of authenticating users in the application.

Overall, the changes in this pull request appear to be a positive improvement to the Agama authentication flow, with a focus on enhancing security and addressing potential issues.

Files Changed:

• docs/script-catalog/person_authentication/agama-bridge/AgamaBridge.py: This file contains the changes related to the Agama authentication flow. The key changes include updating the extractAgamaFlow function to correctly identify the Agama flow, and handling the case where the userId is not present in the flow result.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.