fix(jans-linux-setup): jans ldap link server

[devrimyatar]

closes #9456

• Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

[dryrunsecurity]

DryRun Security Summary

The pull request primarily focuses on updating the installation and configuration of the Jans LDAP Link Server, a component of the Jans platform, including renaming the component, updating the installation and configuration scripts, and ensuring the appropriate variables and service names are used.

Expand for full summary

Summary:

The code changes in this pull request are primarily focused on updating the installation and configuration of the Jans LDAP Link Server, a component of the Jans platform. The key changes include:

1. Renaming the "Jans Link Server" to "Jans LDAP Link Server" throughout the codebase, including in configuration settings, command-line arguments, and installation prompts.
2. Updating the installation and configuration scripts to handle the new "Jans LDAP Link Server" component, including changes to the JansLinkInstaller class and the collect_properties.py and setup_options.py utility files.
3. Ensuring that the appropriate variables and service names are used to track the installation and configuration of the Jans LDAP Link Server.

From an application security perspective, these changes do not appear to introduce any obvious security vulnerabilities. The updates are primarily focused on renaming and reorganizing the components related to the LDAP link functionality, which should not have a direct impact on the overall security of the Jans platform.

However, it's important to note that the Jans platform handles sensitive information, such as database credentials, encryption keys, and user authentication data. As such, it's crucial to review the entire codebase and deployment process to ensure that appropriate security measures are in place, including secure storage of sensitive data, proper input validation and sanitization, and adherence to security best practices.

Additionally, the installation and configuration of the various Jans components, including the LDAP link, can have security implications. It's essential to review the security configurations and settings for each component to ensure that they are properly secured and aligned with the application's security requirements.

Files Changed:

1. jans-linux-setup/jans_setup/setup_app/config.py: The change updates the value of the install_jans_ldap_link property from False to False, which does not appear to have any significant security implications.
2. docs/admin/install/setup.md: The changes update the terminology from "Jans Link Server" to "Jans LDAP Link Server" and the corresponding command-line option, which is a straightforward update.
3. jans-linux-setup/jans_setup/setup_app/installers/jans.py: The changes update the installation and service management processes to reflect the new "Jans LDAP Link Server" name, which is a necessary update to maintain consistency.
4. jans-linux-setup/jans_setup/setup_app/installers/config_api.py: The changes are focused on the installation and configuration of the Jans Config API, which includes handling various plugins, OAuth2 settings, and client configurations. These changes should be reviewed to ensure that the security implications are properly addressed.
5. jans-linux-setup/jans_setup/setup_app/utils/arg_parser.py: The changes update the command-line argument parser to reflect the new "Jans LDAP Link Server" name, which is a straightforward update.
6. jans-linux-setup/jans_setup/setup_app/installers/jans_link.py: The changes update the JansLinkInstaller class to handle the new "Jans LDAP Link Server" component, which should be reviewed to ensure that the security implications are properly addressed.
7. jans-linux-setup/jans_setup/setup_app/utils/collect_properties.py: The change updates a variable name from Config.install_jans_link to Config.install_jans_ldap_link, which is a necessary update to maintain consistency.
8. jans-linux-setup/jans_setup/setup_app/setup_options.py: The change updates the 'install_jans_link' option to 'install_jans_ldap_link', which is a necessary update to maintain consistency.
9. jans-linux-setup/jans_setup/setup_app/utils/properties_utils.py: The changes update the user prompts and variable names to reflect the new "Jans LDAP Link Server" component, which is a necessary update to maintain consistency.

Code Analysis

We ran 9 analyzers against 9 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer	Findings
Authn/Authz Analyzer	7 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[sonarqubecloud]

Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud