-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(terraform-provider-jans): update terraform module #9464
Conversation
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
DryRun Security SummaryThe provided code changes cover a wide range of updates and improvements to the Expand for full summarySummary: The provided code changes cover a wide range of updates and improvements to the From an application security perspective, the changes generally do not introduce any obvious security vulnerabilities. However, there are a few areas that require attention to ensure the continued security and reliability of the Jans integration:
Overall, the changes appear to be focused on improving the functionality and usability of the Terraform provider, while maintaining a reasonable level of security. However, it is essential to continue reviewing the codebase and the broader context of the application to ensure that the integration with the Jans platform remains secure and resilient. Files Changed:
Code AnalysisWe ran
Riskiness🟢 Risk threshold not exceeded. |
DisableLoggerTimer bool `schema:"disable_logger_timer" json:"disableLoggerTimer"` | ||
DisableAuditLogger bool `schema:"disable_audit_logger" json:"disableAuditLogger"` | ||
CustomAttributeValidationEnabled bool `schema:"custom_attribute_validation_enabled" json:"customAttributeValidationEnabled"` | ||
ArcValidationEnabled bool `schema:"arc_validation_enabled" json:"arcValidationEnabled"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be acrValidationEnabled
?
"acrValidationEnabled": true, |
ModuleNameValidationEnabled bool `schema:"module_name_validation_enabled" json:"moduleNameValidationEnabled"` | ||
AssetBaseDirectory string `schema:"asset_base_directory" json:"assetBaseDirectory"` | ||
JansServiceModule []string `schema:"jans_service_module" json:"jansServiceModule"` | ||
AssetDirMappings []AssetDirMapping `schema:"asset_dir_mappings" json:"assetDirMappings"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The json:"assetDirMappings"
likely need to be rename to json:"assetDirMapping"
?
"assetDirMapping":[ |
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
* fix(terraform-provider-jans): update terraform provider Signed-off-by: moabu <47318409+moabu@users.noreply.github.com> * fix: fix references for acr and app configuration Signed-off-by: moabu <47318409+moabu@users.noreply.github.com> --------- Signed-off-by: moabu <47318409+moabu@users.noreply.github.com> Former-commit-id: c15ccfe
Bug Fixes
Closes fix(terraform-provider-jans): update terraform module with the API changes for 1.1.5 #9465,