Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-cli-tui): duplicate schema names in info #9481

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

devrimyatar
Copy link
Contributor

closes #9371

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-tui labels Sep 12, 2024
Copy link

dryrunsecurity bot commented Sep 12, 2024

DryRun Security Summary

The pull request focuses on improving the display of schema information for the API operations in the jans-cli-tui project, including checking for schema references, adding schema names to the list of schemas to be displayed, and providing a message to suggest how to get a sample schema template for the operation.

Expand for full summary

Summary:

The code changes in this pull request are focused on improving the display of schema information for the API operations in the jans-cli-tui project. The key changes include checking if the requestBody of the API operation contains a schema reference, adding the schema name to the list of schemas to be displayed, and ensuring that each schema is only displayed once. Additionally, the code adds a message at the end of the help_for function to suggest how to get a sample schema template for the operation.

From an application security perspective, these changes do not introduce any obvious security concerns. The changes are primarily focused on enhancing the user experience by providing more detailed information about the API operations and their associated schemas. This is a reasonable improvement to the CLI tool, as it makes it easier for users to understand the expected input and output data structures for the various API operations.

Files Changed:

  • jans-cli-tui/cli_tui/cli/config_cli.py: The changes in this file are focused on improving the display of schema information for the API operations. The code now checks if the requestBody of the API operation contains a schema reference, adds the schema name to the list of schemas to be displayed, and ensures that each schema is only displayed once. Additionally, a message is added at the end of the help_for function to suggest how to get a sample schema template for the operation.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added the comp-jans-cli-tui Component affected by issue or PR label Sep 12, 2024
Copy link

@yuriyz yuriyz merged commit 4e3941c into main Sep 12, 2024
12 checks passed
@yuriyz yuriyz deleted the jans-cli-tui-scim-schema-9371 branch September 12, 2024 19:11
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Former-commit-id: 4e3941c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cli-tui Component affected by issue or PR comp-jans-tui kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-cli): Duplicate lines for schema definition of SCIM in Jans CLI
4 participants