Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-conf-api): evaluationTimeNs should be integer #9492

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

yurem
Copy link
Contributor

@yurem yurem commented Sep 13, 2024

Signed-off-by: Yuriy Movchan Yuriy.Movchan@gmail.com

closes #9487

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
@yurem yurem requested a review from yuremm September 13, 2024 15:15
@yurem yurem requested review from pujavs and yuriyz as code owners September 13, 2024 15:15
Copy link

dryrunsecurity bot commented Sep 13, 2024

DryRun Security Summary

The pull request modifies the TelemetryEntry class by changing the data types of the lastPolicyEvaluationTimeNs and avgPolicyEvaluationTimeNs fields from Date to int, and updating the corresponding getter and setter methods.

Expand for full summary

Summary:

The code changes in this pull request appear to be a modification to the TelemetryEntry class in the jans-config-api/plugins/lock-plugin/src/main/java/io/jans/configapi/plugin/lock/model/stat/ directory. The key changes are the data type changes for the lastPolicyEvaluationTimeNs and avgPolicyEvaluationTimeNs fields from Date to int. The corresponding getter and setter methods have also been updated to reflect this change.

From an application security perspective, this change does not appear to introduce any significant security concerns, as the TelemetryEntry class seems to be a data model class used for storing telemetry information. The change in data types for the policy evaluation time fields is likely a technical change to better represent the data being stored. However, it's important to ensure that the change in data type does not result in any loss of precision or accuracy in the stored telemetry data, and that the data is being properly handled and secured throughout the application.

Files Changed:

  • jans-config-api/plugins/lock-plugin/src/main/java/io/jans/configapi/plugin/lock/model/stat/TelemetryEntry.java: The data types of the lastPolicyEvaluationTimeNs and avgPolicyEvaluationTimeNs fields have been changed from Date to int, and the corresponding getter and setter methods have been updated accordingly.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Sep 13, 2024
@yuremm yuremm enabled auto-merge (squash) September 13, 2024 15:16
Copy link

@yuremm yuremm merged commit 5b911a7 into main Sep 13, 2024
12 checks passed
@yuremm yuremm deleted the exec_time branch September 13, 2024 15:28
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Former-commit-id: 5b911a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans-lock): add endpoints to allow send bulk audit data
4 participants