Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream Episode 17: Initial SharedPreferences storage implementation #81

Merged
merged 19 commits into from
Oct 17, 2018
Merged

Stream Episode 17: Initial SharedPreferences storage implementation #81

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ab05bcc
Scaffold sharedpreferences module
JoaquimLey Oct 11, 2018
3f64e3d
Small configurations for CI
JoaquimLey Oct 12, 2018
e442738
Test removing ViewModelModule
JoaquimLey Oct 12, 2018
81bdb3d
Ci why you no work?
JoaquimLey Oct 12, 2018
d953bf8
Fix lints on CI
JoaquimLey Oct 12, 2018
fc0d1fd
Working stuff for CI
JoaquimLey Oct 12, 2018
eafd9af
housekeeping mobile-ui/build.gradle
JoaquimLey Oct 13, 2018
dcc8c23
Rename data package to include project name
JoaquimLey Oct 13, 2018
80670ed
Remove unecessary .gitignore from other packages
JoaquimLey Oct 13, 2018
c1804a1
Manifest cleanup and format
JoaquimLey Oct 13, 2018
0ccd949
Scaffold stuff for stream episode 17
JoaquimLey Oct 14, 2018
2fc6290
Housekeeping from previous commit
JoaquimLey Oct 14, 2018
472d8be
Fix typo in readme
JoaquimLey Oct 15, 2018
ec8b41c
Include kotlinx.serialization experimental library for sharedPrefs
JoaquimLey Oct 16, 2018
16d03c1
Make SharedPrefTransport model @kotlinx.serialization.Serializable
JoaquimLey Oct 16, 2018
96ddc7e
Merge with develop
JoaquimLey Oct 16, 2018
7b6fbf1
SharedPrefMapper tests
JoaquimLey Oct 17, 2018
c2a90fe
Initial tests for FrameworkLocalStorageImpl
JoaquimLey Oct 17, 2018
002bcc0
Include stream episode PR to README
JoaquimLey Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test removing ViewModelModule
  • Loading branch information
@JoaquimLey
JoaquimLey committed Oct 12, 2018

Unverified

No user is associated with the committer email.
Learn about vigilant mode
commit e442738de2d2a143abbd2f40aed68fbd5e49f810
4 changes: 0 additions & 4 deletions transport-eta-android/data-sharedpreferences/build.gradle
View file
Original file line number Diff line number Diff line change
@@ -4,8 +4,6 @@ apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'

android {
publishNonDefault true

compileSdkVersion build_versions.target_sdk
defaultConfig {
minSdkVersion build_versions.min_sdk
@@ -80,12 +78,10 @@ androidExtensions {
dependencies {
// Module
implementation project(':data')

// ACC
kapt deps.lifecycle.compiler
implementation deps.lifecycle.livedata
implementation deps.lifecycle.viewmodel

// Javax
implementation deps.javax.inject
compileOnly deps.javax.annotation
1 change: 0 additions & 1 deletion transport-eta-android/data/build.gradle
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@ configurations.all {
dependencies {
// Modules
implementation project(':domain')

// Javax
implementation deps.javax.inject
compileOnly deps.javax.annotation
4 changes: 0 additions & 4 deletions transport-eta-android/presentation/build.gradle
View file
Original file line number Diff line number Diff line change
@@ -4,8 +4,6 @@ apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'

android {
publishNonDefault true

compileSdkVersion build_versions.target_sdk
defaultConfig {
minSdkVersion build_versions.min_sdk
@@ -77,12 +75,10 @@ androidExtensions {
dependencies {
// Module
implementation project(':domain')

// ACC
kapt deps.lifecycle.compiler
implementation deps.lifecycle.livedata
implementation deps.lifecycle.viewmodel

// Javax
implementation deps.javax.inject
compileOnly deps.javax.annotation
2 changes: 0 additions & 2 deletions transport-eta-android/sms/build.gradle
View file
Original file line number Diff line number Diff line change
@@ -3,8 +3,6 @@ apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'

android {
publishNonDefault true

compileSdkVersion build_versions.target_sdk
defaultConfig {
minSdkVersion build_versions.min_sdk
7 changes: 3 additions & 4 deletions ...bile/src/main/java/com/joaquimley/transporteta/ui/di/module/HomeFragmentBuildersModule.kt
View file
Original file line number Diff line number Diff line change
@@ -2,13 +2,12 @@ package com.joaquimley.transporteta.ui.di.module

import com.joaquimley.transporteta.ui.home.favorite.FavoritesFragment
import dagger.Module
import dagger.android.ContributesAndroidInjector

@Module
abstract class HomeFragmentBuildersModule {

@ContributesAndroidInjector(modules = [
ViewModelModule::class
])
// @ContributesAndroidInjector(modules = [
// ViewModelModule::class
// ])
abstract fun contributeFavouritesFragment(): FavoritesFragment
}
6 changes: 2 additions & 4 deletions ...ui-mobile/src/main/java/com/joaquimley/transporteta/ui/home/favorite/FavoritesFragment.kt
View file
Original file line number Diff line number Diff line change
@@ -32,10 +32,7 @@ import javax.inject.Inject
*/
class FavoritesFragment : Fragment() {

// Inspiration for UI https://www.behance.net/gallery/69860023/Bust-app

@Inject
lateinit var viewModelProvider: FavoritesViewModelFactory
@Inject lateinit var viewModelProvider: FavoritesViewModelFactory
private val viewModel by lazy { viewModelProvider.create() }

private lateinit var adapter: FavoritesAdapter
@@ -47,6 +44,7 @@ class FavoritesFragment : Fragment() {
}

override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?):
// TODO Inspiration for UI https://www.behance.net/gallery/69860023/Bust-app
View = inflater.inflate(R.layout.fragment_favourites, container, false)

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {