Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip trailing comma in displaying a 1D CartesianIndex #57709

Merged
merged 2 commits into from
Mar 15, 2025
Merged

Skip trailing comma in displaying a 1D CartesianIndex #57709

merged 2 commits into from
Mar 15, 2025

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 11, 2025 •
edited
Loading

On nightly v"1.13.0-DEV.186",

julia> CartesianIndex(3)
CartesianIndex(3,)

This PR

julia> CartesianIndex(3)
CartesianIndex(3)

The trailing comma is removed in the displayed form.

@jishnub jishnub added the display and printing Aesthetics and correctness of printed representations of objects. label Mar 11, 2025
barucden
barucden reviewed Mar 11, 2025
View reviewed changes
jishnub
jishnub commented Mar 11, 2025
View reviewed changes
Copy link
Member Author

@jishnub jishnub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested, it should be possible join instead of adding another helper method

@jishnub jishnub merged commit 22805e6 into master Mar 15, 2025
5 of 7 checks passed
@jishnub jishnub deleted the jishnub/CartesianIndex_show branch March 15, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barucden barucden barucden left review comments

Assignees
No one assigned
Labels
display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jishnub @barucden