Skip to content

Install tensorflow-addons #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Install tensorflow-addons #668

wants to merge 2 commits into from

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Dec 2, 2019

Fixes #638

@rosbo rosbo requested a review from erdalsivri December 2, 2019 18:36
Copy link
Contributor

@erdalsivri erdalsivri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosbo
Copy link
Contributor Author

rosbo commented Dec 2, 2019

The test is failing with:

tensorflow.python.framework.errors_impl.NotFoundError: /opt/conda/lib/python3.6/site-packages/tensorflow_addons/custom_ops/activations/_activation_ops.so: undefined symbol: _ZN10tensorflow12OpDefBuilder4AttrESs

Based on tensorflow/addons#574, this is because TF and TFA were built with different compilers. Because we are building TF from source to optimize it for our CPU, it creates a mismatch with the pre-built TFA binaries from pypi.

We should build TFA from source to ensure the compiler match.

@lovemeblender
Copy link

Useful change - are you guys moving forward with this?

@pairwiserr
Copy link

!pip install tensorflow-addons
import tensorflow_addons
NotFoundError: /opt/conda/lib/python3.6/site-packages/tensorflow_addons/custom_ops/activations/_activation_ops.so: undefined symbol: __cudaRegisterFatBinaryEnd

On latest available docker-python with GPU on.

@rosbo
Copy link
Contributor Author

rosbo commented Jan 10, 2020

Yes, we are still planning to move forward with this but we will need a bit more work to build our own wheels. This is on my radar but not on top of my priority list. Hopefully, I should get to it over the next couple of weeks.

@rosbo
Copy link
Contributor Author

rosbo commented May 20, 2020

Closed in favor #816

@rosbo rosbo closed this May 20, 2020
@rosbo rosbo deleted the tf-addons branch May 20, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tensorflow-addons
4 participants