Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed conflict on macos bigsur #77

Closed
wants to merge 1 commit into from

Conversation

koojongin
Copy link

@koojongin koojongin commented Jul 27, 2021

when use macos, version big sur
nes-py module is only running on pyglet>=1.5.1
openai/gym#2101

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Fixes #

Type of change

Please select all relevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration

  • Operating System:
  • Python version:
  • C++ compiler version:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

when use macos, version big sur
nes-py module is only running on pyglet>=1.5.1
openai/gym#2101
@Kautenja
Copy link
Owner

Updated master branch with the change, I actually found 1.5.11 to be necessary for MacOS Big Sur

@Kautenja Kautenja closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants