Excluding private modifiers for mock members #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainayanda
force-pushed
the
excluding-private-modifiers
branch
from
8419a26 to
4963a23
Compare
Kolos65
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Thanks for the PR @hainayanda 🚀
I have 3 minor changes requested. (also there is an issue with the CI build, I will fix that soon)
Sources/MockableMacro/Extensions/DeclModifierListSyntax+Extensions.swift
Outdated
Show resolved
Hide resolved
|
I fixed the CI build issue, pls rebase. |
hainayanda
force-pushed
the
excluding-private-modifiers
branch
from
4963a23 to
c4a5dee
Compare
|
@Kolos65 rebased and resolved according to your comment. Please proceed. |
Kolos65
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude private modifiers for mock members like function, init, properties, etc.
This is to address my reported issues here