Fix name collisions #81
Merged
+722
−654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kolos65
force-pushed
the
fix-name-collisions
branch
from
cabf04a to
5617b6f
Compare
Kolos65
force-pushed
the
fix-name-collisions
branch
from
5617b6f to
c774d42
Compare
|
Thanks for the quick response and implementation! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid any future name collisions, this PR updates the macro to use fully qualified identifiers in macro generated code. In order to avoid name collision between the module
Mockableand the existingMockableprotocol, it was renamed toMocked.Thanks @wvteijlingen-npo for the issue and the solution idea. 🎉