Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use legacy issue-reporting package name for compatibility #84

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Kolos65
Copy link
Owner

@Kolos65 Kolos65 commented Oct 15, 2024

Pointfree packages use the old name of swift-issue-reporting in their package manifest:

all have

.package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay", from: "1.3.0")

in the manifest.

This means, that if Mockable uses the new swift-issue-reporting package name instead of the old one, you will get the following duplication error if you try to depend on Mockable and TCA together:

multiple similar targets 'IssueReporting', 'IssueReportingTestSupport', 'XCTestDynamicOverlay' appear in package 'swift-issue-reporting' and 'xctest-dynamic-overlay', this may indicate that the two packages are the same and can be de-duplicated by using mirrors. if they are not duplicate consider using the moduleAliases parameter in manifest to provide unique names

In order to avoid conflicts with pointfree packages which are quite popular, this PR renames the dependency to follow them in this regard.

@Kolos65 Kolos65 merged commit 84c4f7f into main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant