Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include doc comments on the generated protocol #97

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Include doc comments on the generated protocol #97

merged 2 commits into from
Jan 2, 2025

Conversation

SagarSDagdu
Copy link
Contributor

@SagarSDagdu SagarSDagdu commented Dec 20, 2024 •
edited
Loading

Fixes #96 by includingleadingTrivia

@SagarSDagdu SagarSDagdu mentioned this pull request Dec 20, 2024
Closed
@SagarSDagdu
Copy link
Contributor Author

rebased and changed commit messages to respect the linter

ben-p-commits
ben-p-commits approved these changes Jan 2, 2025
View reviewed changes
Copy link

@ben-p-commits ben-p-commits left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you for adding this.

My useless read-only approval is purely symbolic @SagarSDagdu 🙇🏻 . Thanks again!

@Kolos65 Kolos65 merged commit 60f3f47 into Kolos65:main Jan 2, 2025
4 checks passed
@Kolos65
Copy link
Owner

Kolos65 commented Jan 2, 2025

Thanks @SagarSDagdu 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-p-commits ben-p-commits ben-p-commits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Including doc comments from protocol being mocked?
3 participants
@SagarSDagdu @Kolos65 @ben-p-commits