Skip to content

Add client unlink callbacks #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Conversation

MichaelBrim
Copy link
Collaborator

Description

This callback informs clients that they should cleanup any associated file state, including releasing storage for unsynced extents. The callback rpc is only sent to clients that have previously registered extents with their local server.

The client callback support in the request manager thread has been designed to make it easy to add other callbacks in the future.

Also:

  • adds an integer flag to the logio header to avoid concurrent updates by the client and server.
  • adds a program option (-u|--unlink) to examples to unlink target file
  • adds a new arraylist_sort() method

Motivation and Context

Fixes a few of the deficiencies identified in review of PR #656

How Has This Been Tested?

Tested in Ubuntu Docker and on OLCF Summit

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing (addition of new tests or update to current tests)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the UnifyFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted.

@MichaelBrim MichaelBrim force-pushed the unlink-client-callback branch from 1e2fcef to 60600a8 Compare August 4, 2021 19:24
This callback informs clients that they should cleanup any
associated file state, including releasing storage for
unsynced extents. The callback rpc is only sent to clients
that have previously registered extents with their local
server.

Also:
* adds an integer flag to the logio header to avoid
  concurrent updates by the client and server.
* adds a program option to examples to unlink target file
* adds a new arraylist_sort() method
Copy link
Collaborator

@adammoody adammoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @MichaelBrim . Wow, that's a lot of new stuff, and the new general support for client rpcs will be useful.

@adammoody adammoody merged commit e22863d into LLNL:dev Aug 10, 2021
@MichaelBrim MichaelBrim deleted the unlink-client-callback branch August 11, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants