Skip to content

Update mochi-margo dependency to 0.13.1 #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 1, 2023
Merged

Conversation

MichaelBrim
Copy link
Collaborator

Description

Updates to support using the latest version of mochi-margo, v0.13.1.
Probably also enables building with other versions of mochi-margo back to v0.10, but I did not test those versions.

Motivation and Context

Gets us the latest and greatest features/fixes for mochi-margo, mercury, and argobots.

How Has This Been Tested?

Verified I can build and run on both OLCF Summit and Crusher/Frontier. On these systems, spack ended up choosing mercury/2.2.0 and argobots/1.1 as the versions to use for margo's deps.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing (addition of new tests or update to current tests)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the UnifyFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted.

@MichaelBrim
Copy link
Collaborator Author

The CI builds are failing because we need the latest spack, since mochi-margo 0.13.1 was only released about a month ago

- Checkout develop branch of spack for latest mochi-margo
- Update checkout action to remove warning
- Update packages.yaml
- Add `spack external find` to locate correct cmake
- Edit spack config to use old behavior of `spack load` updating
`LD_LIBRARY_PATH`
- Update `PKG_CONFIG_PATH` so all compilers can find openssl
@CamStan
Copy link
Member

CamStan commented Apr 26, 2023

Added a commit to update the CI to the latest Spack. Changing one thing kept breaking something else, but finally got it there.
As you mentioned this is now checking out the spack develop branch. Once the latest release of mochi-margo is in a spack release, we may want to change this to make it more stable.

@MichaelBrim MichaelBrim marked this pull request as ready for review May 1, 2023 12:10
@adammoody adammoody merged commit 1b509ff into LLNL:dev May 1, 2023
@MichaelBrim MichaelBrim deleted the update-deps branch May 1, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants