fix: not detected edges values DTCMP_Rank* #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the rank does not valid value but one of its side has, pretend rank is valid with this value to the other side. This fixes some cases with specific layouts of ranks without values. fix LLNL#19 Signed-off-by: Rémi Palancher <remi@rackslab.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the rank does not valid value but one of its side has, pretend rank is valid with this value to the other side. This fixes some cases with specific layouts of ranks without values.
For the record, I encountered this bug while adding support of hardlinks in mpifileutils. I need a fix for this bug so that this feature works reliably in all my test cases.
fix #19