Skip to content
This repository was archived by the owner on Jun 27, 2022. It is now read-only.

Add AVAX to currencies.ts #629

Merged
merged 6 commits into from
Oct 11, 2021
Merged

Add AVAX to currencies.ts #629

merged 6 commits into from
Oct 11, 2021

Conversation

ApolloUnicorn
Copy link
Contributor

No description provided.

@gre
Copy link
Contributor

gre commented Jul 13, 2021

@ApolloUnicorn can you run "yarn prettier"? Thanks

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #629 (1833067) into master (893232a) will not change coverage.
The diff coverage is n/a.

❗ Current head 1833067 differs from pull request most recent head beaa174. Consider uploading reports for the commit beaa174 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #629   +/-   ##
=======================================
  Coverage   42.48%   42.48%           
=======================================
  Files          72       72           
  Lines        4272     4272           
  Branches      713      713           
=======================================
  Hits         1815     1815           
  Misses       2440     2440           
  Partials       17       17           
Impacted Files Coverage Δ
packages/cryptoassets/src/currencies.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 893232a...beaa174. Read the comment docs.

@gre gre marked this pull request as draft July 27, 2021 14:08
@ApolloUnicorn
Copy link
Contributor Author

@ApolloUnicorn can you run "yarn prettier"? Thanks

@gre done

@ApolloUnicorn ApolloUnicorn marked this pull request as ready for review October 8, 2021 16:04
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like CI still find an issue


/home/runner/work/ledgerjs/ledgerjs/packages/cryptoassets/src/currencies.ts
Error:   1340:12  error    Insert `⏎·········`              prettier/prettier

@ApolloUnicorn ApolloUnicorn requested a review from gre October 8, 2021 21:07
@ApolloUnicorn
Copy link
Contributor Author

Turns out that was from another chain, so not sure how that would up being a problem to begin with.

@gre
Copy link
Contributor

gre commented Oct 11, 2021

mmh I think you use a different prettier version than the one from the node_modules. i'll fix this after merge.

@gre gre merged commit 22d25d0 into LedgerHQ:master Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants