Skip to content

✨ Add distance sensor hardware class #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Miniongolf
Copy link
Contributor

@Miniongolf Miniongolf commented Mar 4, 2025

Add distance sensor hardware class

Download the template for this pull request:

Note

This is auto generated from Add Template to Pull Request

curl -o hardware@0.4.2+e70f64.zip https://nightly.link/LemLib/hardware/actions/artifacts/2690873636.zip;
pros c fetch hardware@0.4.2+e70f64.zip;
pros c apply hardware@0.4.2+e70f64;
rm hardware@0.4.2+e70f64.zip;

@Miniongolf Miniongolf changed the title Add distance sensor hardware class ✨ Add distance sensor hardware class Mar 4, 2025
@SizzinSeal
Copy link
Member

has this been tested?

@Miniongolf
Copy link
Contributor Author

not yet, I'll test it sometime this week

For offsets, should I add a setter for what the sensor should read (e.g. if the user sets distance to 5 in and the sensor reads 2 in, the offset gets set to 3 in) or is just having a direct write to offset fine?

@Miniongolf
Copy link
Contributor Author

Miniongolf commented Mar 4, 2025

also just fyi, the add template to pull request workflow doesn't seem to work

This is what happens when I click the manual download nightly link
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants