Fix mypy errors attributed to pytorch_lightning.core.mixins.device_dtype_mixin
#13704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnakalyan3
requested review from
tchaton,
SeanNaren,
Borda,
carmocca,
justusschock,
kaushikb11,
williamFalcon,
awaelchli and
rohitgr7
as code owners
for more information, see https://pre-commit.ci
otaj
reviewed
Jul 18, 2022
awaelchli
suggested changes
Jul 18, 2022
carmocca
reviewed
Jul 18, 2022
…ytorch-lightning into mypy_device_dtype_mixin
for more information, see https://pre-commit.ci
…ytorch-lightning into mypy_device_dtype_mixin
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #13704 +/- ##
=========================================
- Coverage 86% 76% -10%
=========================================
Files 328 328
Lines 25601 25597 -4
=========================================
- Hits 22008 19559 -2449
- Misses 3593 6038 +2445 |
awaelchli
approved these changes
Jul 24, 2022
otaj
approved these changes
Jul 25, 2022
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
|
Thankyou @awaelchli for the feedback!. |
rohitgr7
approved these changes
Jul 25, 2022
Borda
approved these changes
Jul 26, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13445