Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4754 Add all new strings related to Field Technology to integration #3712

Conversation

kathyavini
Copy link
Collaborator

Description

Referenced Figma here. There were only two legitimately new strings, plus several variations on strings already in app. (Nonetheless I just kept them as Loïc had them in this view and added the variations).

Fixed one tiny interpolated string issue that will not impact on what gets sent to CrowdIn but will change capitalization in app.

Jira link: https://lite-farm.atlassian.net/browse/LF-4754

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Strings only with no components; not tested.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini added the new translations New translations to be sent to CrowdIn are present label Mar 13, 2025
@kathyavini kathyavini self-assigned this Mar 13, 2025
@kathyavini kathyavini requested review from a team as code owners March 13, 2025 18:57
@kathyavini kathyavini requested review from antsgar and Duncan-Brain and removed request for a team March 13, 2025 18:57
@@ -83,7 +83,7 @@ const Partners = ({ hasActiveConnection }: PartnersProps) => {
<Main className={styles.infoText}>{t('SENSOR.ESCI.ACTIVE_CONNECTION')}</Main>
<Link className={styles.manage} to={{ pathname: '/farm', hash: '#esci-addon' }}>
<ExternalLinkIcon />
<span>{t('common:MANAGE_ENTITY', { entity: 'ESCI' })}</span>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the "ESCI" here:

Screenshot 2025-03-13 at 11 46 06 AM

@kathyavini kathyavini changed the title Lf 4754 add all new strings related to field technology to integration LF-4754 Add all new strings related to Field Technology to integration Mar 13, 2025
@kathyavini
Copy link
Collaborator Author

I'm going to merge with one approval so it can go up to CrowdIn but @antsgar do message if you spot something off later 🙏

@kathyavini kathyavini added this pull request to the merge queue Mar 13, 2025
Merged via the queue into integration with commit 9374683 Mar 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new translations New translations to be sent to CrowdIn are present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants