Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] LF-4699 (2): Display sensor readings on the UI #3726

Draft
wants to merge 58 commits into
base: integration
Choose a base branch
from

Conversation

SayakaOno
Copy link
Collaborator

@SayakaOno SayakaOno commented Mar 28, 2025

WIP!

Description

  • Update LineChart to make title and xAxis tick colour customizable
  • Update getTicks to accept dates as Date instead of string (tests and stories adjusted)
  • Update SelectionHandler, useSelectionHandler, and SensorDetailsRoutes to display the sensor details page when a sensor icon or cluster popup on the map is clicked (old sensors will still navigate to the old page)

Jira link: https://lite-farm.atlassian.net/browse/LF-4699

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

* create SensorCharts component using useFormattedSensorReadings hook
@SayakaOno SayakaOno self-assigned this Mar 28, 2025
@SayakaOno SayakaOno added enhancement New feature or request new translations New translations to be sent to CrowdIn are present labels Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft enhancement New feature or request new translations New translations to be sent to CrowdIn are present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant