-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] LF-4699 (2): Display sensor readings on the UI #3726
Draft
SayakaOno
wants to merge
58
commits into
integration
Choose a base branch
from
LF-4699/Display_sensor_readings_on_the_UI_2
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] LF-4699 (2): Display sensor readings on the UI #3726
SayakaOno
wants to merge
58
commits into
integration
from
LF-4699/Display_sensor_readings_on_the_UI_2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update format functions
…ensorReadings hook
* create SensorCharts component using useFormattedSensorReadings hook
… to be reverted)" This reverts commit 1d5fafa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
draft
enhancement
New feature or request
new translations
New translations to be sent to CrowdIn are present
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP!
Description
LineChart
to maketitle
andxAxis
tick colour customizablegetTicks
to accept dates asDate
instead ofstring
(tests and stories adjusted)SelectionHandler
,useSelectionHandler
, andSensorDetailsRoutes
to display the sensor details page when a sensor icon or cluster popup on the map is clicked (old sensors will still navigate to the old page)Jira link: https://lite-farm.atlassian.net/browse/LF-4699
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: