Add utility functions to convert to/from JSON #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains templated utility functions to (de-)serialize an object from/to JSON strings using cereal.
Only required dependencies should use `find_dependency` (and _not_ have the REQUIRED keyword), while for optional dependencies one should stick to `find_package`. See https://stackoverflow.com/a/64847834/2095383 This fixes a build error if a package depends on serialization_utils but OpenCV is not available.
|
|
||
| # optional dep | ||
| find_dependency(OpenCV QUIET) | ||
| find_package(OpenCV QUIET) |
There was a problem hiding this comment.
for my education: what is the difference ?
There was a problem hiding this comment.
It forwards the REQUIRED or QUIET parameters of the original find_package call (i.e. find_package(serialization_utils ...)). I think the reasoning is that if serialization_utils itself is only required as optional dependency, it should not fail the build if one of its dependencies is not there.
On the other hand, this means that if serialization_utils is required, all the find_dependency calls automatically become required too (to my understanding the QUIET parameter was simply ignored here), which is not desired for optional dependencies.
See https://stackoverflow.com/a/64847834/2095383
vincentberenz
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple functions that wrap the code for converting an object to/from a JSON string (or stream) using cereal.
They were implemented in vicon_transformer originally, but since they are very generic, I think it makes more sense to have them here.
This PR also fixes an issue in the CMake config: Optional dependencies should use
find_packageand notfind_dependencyin the Config.cmake.in. Further, theREQUIREDkeyword should not be used there.