Skip to content

Updates to CI and fix tests #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2021
Merged

Updates to CI and fix tests #68

merged 3 commits into from
Dec 12, 2021

Conversation

naveen521kk
Copy link
Member

@naveen521kk naveen521kk commented Dec 4, 2021 •
edited
Loading

  • tests: fix test warning, use absolute path
  • Don't use windows-2016 (it's nearing EOL) see CI: Windows-2016 environment will be removed soon #66
  • Upgrade dependencies for the build
  • Don't build subprojects manually on macOS build
  • Add separate test workflow and not use docker in tests
  • Only upload wheels if tests pass
  • Include license files in all the wheels
  • Link wheels statically on macOS

PhilippImhof
PhilippImhof previously approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@PhilippImhof PhilippImhof left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have to do something about the failing build?

cibuildwheel 2.x no longer supports Python < 3.6. Please use the 1.x series or update CIBW_SKIP
Error: Command source packing/build_pango_mac.sh && pip install cython && cd manimpango && cythonize cmanimpango.pyx -3 -k -f && cd ../ && pip install . && pkg-config --libs pango failed with code 1. None

Error: Process completed with exit code 1.

@naveen521kk naveen521kk marked this pull request as draft December 4, 2021 10:21
@naveen521kk
Copy link
Member Author

Do we have to do something about the failing build?

Ah, sorry I didn't mark it as a draft. It's still a WIP.

@PhilippImhof
Copy link
Member

Ah, sorry I didn't mark it as a draft. It's still a WIP.

OK, fine. You actually seemed to even have requested a review :)

@naveen521kk
Copy link
Member Author

You actually seemed to even have requested a review :)

I guess that's because you are a Code owner here,

@naveen521kk naveen521kk mentioned this pull request Dec 5, 2021
Merged
@naveen521kk naveen521kk changed the title Updates to CI Updates to CI and fix tests Dec 5, 2021
@naveen521kk
Updates to CI and fix tests
fc145f3 
- tests: fix test warning, use absolute path
- Don't use `windows-2016` (it's nearing EOL) see #66
- Upgrade dependencies for the build
- Don't build subprojects manually on macOS build
- Add separate test workflow and not use docker in tests
- Only upload wheels if tests pass
- Include license files in all the wheels
- Link wheels statically on macOS

Signed-off-by: Naveen M K <naveen521kk@gmail.com>
@naveen521kk naveen521kk marked this pull request as ready for review December 5, 2021 08:44
@naveen521kk
Copy link
Member Author

@PhilippImhof This PR is ready and waiting for your review :).

PhilippImhof
PhilippImhof requested changes Dec 5, 2021
View reviewed changes
Copy link
Member

@PhilippImhof PhilippImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done. I have just a few nitpicks w.r.t consistent language use.

@naveen521kk
Copy link
Member Author

@PhilippImhof Thanks for the review. It would be nice if you could test the macOS wheels also https://github.com/ManimCommunity/ManimPango/suites/4557070397/artifacts/122415312

@naveen521kk @PhilippImhof
Apply suggestions from code review
506b163 
Co-authored-by: Philipp Imhof <52650214+PhilippImhof@users.noreply.github.com>
@PhilippImhof
Copy link
Member

I currently have some environment problems on my machine and thus cannot properly test the macOS wheels. But I think we can go for it, no?

@naveen521kk
Copy link
Member Author

But I think we can go for it, no?

Yeah, I guess at least it works on Github's machine.

PhilippImhof
PhilippImhof approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@PhilippImhof PhilippImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naveen521kk naveen521kk merged commit 51fccd9 into main Dec 12, 2021
@naveen521kk naveen521kk deleted the fix-ci-win branch December 12, 2021 08:53
@naveen521kk
Copy link
Member Author

I'll do a release later today. I guess it should be a major bump right because of #65

@naveen521kk naveen521kk added the chore Maintenance label Dec 12, 2021
This was referenced Dec 26, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippImhof PhilippImhof PhilippImhof approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naveen521kk @PhilippImhof