macOS: build a shared library in wheels #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are we doing about the failing tests? |
I know why the tests were failing https://www.msys2.org/news/#2021-12-21-potential-incompatibilities-with-newer-python-setuptools, I will fix them soon. |
|
Also, it would be better if you test whether the tests work with the in the PR: ManimCommunity/manim#2341 |
|
I will do so, probably tomorrow (UTC+1) |
Normal windows test also fails, I just thought msys2 one failed. I will see what is really happening. |
PhilippImhof
approved these changes
Jan 1, 2022
|
Tested with code from ManimCommunity/manim#2341. Using these wheels, tests work. Using statically linked wheels from main branch, tests crash locally just like they do in CI. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.