Skip to content

v0.1.0 Roadmap #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
9 of 13 tasks
leotrs opened this issue Jun 7, 2020 · 14 comments
Closed
9 of 13 tasks

v0.1.0 Roadmap #148

leotrs opened this issue Jun 7, 2020 · 14 comments
Labels
enhancement Additions and improvements in general help wanted We would appreciate help on this issue/PR refactor Refactor or redesign of existing code release A tracking issue for changes expected for a release
Milestone

Comments

@leotrs
Copy link
Contributor

leotrs commented Jun 7, 2020

There seems to be enough activity on this repo to try and move forward with a release version of the community version of manim. For this, let's use this issue to keep track of what needs to be done and when. Logistically, this should be the last issue to be closed in the v1.0.0 milestone, and once this one is closed, we should be able to push to pypi.

Things that need to be discussed

  1. I think there is a sense among @ManimCommunity/core devs that v1.0.0 should be fully backwards compatible. This has not been fully discussed, however.
  2. For full backwards compatibility, we need to determmine a timeline for deprecation.
  3. It has been decided that this repo will have both manim and manimcm as entrypoints. Some of us have started calling it manim CE (for Community Edition). Personally, I like "manim CE" as a name (and the accompanying manimce entrypoint) more than "manimcm". Though I don't ultimately care either way...
  4. I think it would be nice to have a logo at the time of release Logo #106

Things that need to be implemented

Get rid of CONFIG dicts in each class and migrate to dataclasses #7

Please feel free to edit this issue to add/remove/check off things as you see fit.

After the release

@leotrs leotrs added this to the PyPI Release 1.0.0 milestone Jun 7, 2020
@yoshiask
Copy link
Contributor

yoshiask commented Jun 7, 2020

To be clear, new features like the improved SVG parser and more GraphScene configuration are not slated for the 1.0.0 release?

@leotrs
Copy link
Contributor Author

leotrs commented Jun 7, 2020

Yeah this is exactly what we should discuss here. My personal opinion is that v1.0.0 should be fully backwards compatible, as well as documented and tested, and some of the major problems with the code should be addressed. If that's the case, then a v1.0.0 could be ready in perhaps a couple of months. We could then leave new features for v1.1 release.

Now, if there are new features ready for a v1.0.0 I guess there's no hurt in adding them as long as they are fully backwards compatible. But the intent of this versioning is that most focus should be put into finishing v1.0.0 (i.e. in testing and documenting) before spending our efforts in new features.

Happy to hear different opinions here.

@yoshiask
Copy link
Contributor

yoshiask commented Jun 7, 2020

#7 and #98 are must-haves for this new version. Is #98 backwards compatible?

@leotrs
Copy link
Contributor Author

leotrs commented Jun 7, 2020

Argh, good question. It does support all the same flags (and fixes some of them too), but many variables from constants.py are removed. So no, it's not compatible.

@PgBiel PgBiel added enhancement Additions and improvements in general help wanted We would appreciate help on this issue/PR refactor Refactor or redesign of existing code labels Jun 9, 2020
@PgBiel
Copy link
Member

PgBiel commented Jun 10, 2020

by thursday I should open the draft PR on attrs, typings and docs

@yoshiask yoshiask pinned this issue Jun 11, 2020
@huguesdevimeux
Copy link
Member

@leotrs Could you update this with you work on #98 ?

@leotrs
Copy link
Contributor Author

leotrs commented Jul 10, 2020

Just updated the check list at the top. Please refer to it for what to do next.

@leotrs
Copy link
Contributor Author

leotrs commented Aug 22, 2020

Update: the main thing between us and a release version of ManimCE is the attrs branch. A logo would be nice-to-have but not strictly necessary I think.

@leotrs
Copy link
Contributor Author

leotrs commented Aug 30, 2020

As far as I can tell from yesterday's Discord call, we will try to have the following ready for a 1.0 release:

  1. documentation up on RTD (Read The Docs setup #381 )
  2. pypi package (Package Name On PyPI #202 Package Name On PyPI #202 )
  3. logo
  4. set up poetry Move to Poetry #165

@naveen521kk
Copy link
Member

@leotrs We are using poetry for releasing and stuff. So do add it in list also.

@leotrs
Copy link
Contributor Author

leotrs commented Aug 30, 2020

Good call

@huguesdevimeux
Copy link
Member

(There is a milestone for the release, let's use it ;) )

@naveen521kk
Copy link
Member

naveen521kk commented Sep 1, 2020

Another thing is we need to change manimlib to manim in pyproject.toml #165
Fixed in #534

@eulertour eulertour changed the title Release version 1.0.0 Release version 0.1 Oct 1, 2020
@naveen521kk naveen521kk mentioned this issue Oct 12, 2020
1 task
@leotrs
Copy link
Contributor Author

leotrs commented Oct 15, 2020

Folks, it seems we have completed every item on the list except for the logo, which should be decided upon by Tuesday Oct 20th noon GMT. I suggest we add the logo and also fix #407 and then release this bad boi. Objections? Comments? @ManimCommunity/core

If there are no objections, I move we put a freeze on PRs right now.

@eulertour eulertour unpinned this issue Oct 22, 2020
@eulertour eulertour added the release A tracking issue for changes expected for a release label Oct 22, 2020
@eulertour eulertour changed the title Release version 0.1 Release version 0.1.0 Oct 22, 2020
@eulertour eulertour changed the title Release version 0.1.0 Release v0.1.0 Oct 22, 2020
@eulertour eulertour changed the title Release v0.1.0 v0.1.0 Roadmap Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additions and improvements in general help wanted We would appreciate help on this issue/PR refactor Refactor or redesign of existing code release A tracking issue for changes expected for a release
Projects
None yet
Development

No branches or pull requests

6 participants