-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Make Text and Tex robust against non-existing text_dir and tex_dir #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Naveen M K <naveen@syrusdark.website>
Okay, I've added some very simple Review at will! |
Co-authored-by: Leo Torres <dleonardotn@gmail.com>
I know you're going to hate me for that but ... Do you think you could write a test for that ? |
It is, in fact, already tested with the doctests I have added. :-) |
Could you clarify this ? I don't understand |
@huguesdevimeux The creation of If you would like to have a more explicit test, let me know what precisely you would like to have tested. I'll probably have to adapt to the PR that enabled Pango anyways. |
There was a merge conflict in the I don't find the current co-existance of Anyhow, the reason I bring this up is the representation string: currently, |
I hear that, but I do think that at some point we will need a test for the whole directory generation. |
I would appreciate if this could get a second approval so I can stop resolving merge conflicts over and over. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you! |
List of Changes
TextWithBackground
fromtext_mobject.py
. This was a non-working feature that basically copied code fromText
. Code like that makes manim extremely hard to maintain in the long run. (Actually, also currently.)Motivation
Making
Tex
andText
robust against not created directories is required to use them in a setting where there is noScene
to set everything up (e.g., when writing tests for them outside of a scene, see #476).Testing Status
Added doctests for testing initialization of
Tex
andText
.Acknowledgement