-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Version Information subcommand manim version
#541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Instead of a whole subcommand, I think it'd be better to use a simple |
Complelty agree with this. Is there a way to automatocally update the commit number displayed ? |
I don't think it is possible, as displaying the commit number would mean changing the commit …… |
So why is it possible with other programs? Is it because they are compiled and the compiler adds this info? As an alternative, could we have CI create some unique version-id string with date? |
On every packaged release we have to include a version number. On a version that is not packaged (i.e. it has been installed by cloning the repo), you can just print the latest commit by asking git. No need to hard-code the commit hash. OR we should investigate how "nightly" python packages do this. |
Many programs use just
which would create a new file Then you would have
and maybe
for compiling a scene? but maybe changing CLI UX is all a discussion for another day... |
@cobordism, the So let's keep this issue for discussing the |
Update : It is possible to get the last commit id with subprocess. See here. So, it should be a fairly easy PR :) |
What if the user does ? pip install https://github.com/ManimCommunity/manim/archive/master.zip It will create weird errors. Also, btw chocolatey packages does so to install on windows. @huguesdevimeux |
Of course, I'm an idiot. But, is there like a bot or something to automatically dump into a file the last commit id ? It would be cool |
Something like setuptools-scm can be used I think. But I don't how well it will work. |
So here are the use cases I can think of for this:
|
As soon as we have actual releases as well as a development branch, it is important to know where a user is at. "Latest" can then refer to at least 2 different states. If someone has questions, we can tell them to run |
Fair. How do we do it? For release versions, we can hard-code the version number (and in fact this is required for pypi I think). |
Hardcoding is the best way while release because other alternatives like |
Feature request
implement a
manim version
command.What should the command do?
Tell you exactly which version of manim you are running. Either release number or commit-hash and date
Why?
It makes it easier to help people with their problems.
It makes it easier to catch error arising due to multiple versions being installed locally.
The text was updated successfully, but these errors were encountered: