-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Manim Project Creating Subcommand #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I like this idea. I'd suggest the command be |
This command should create should project structure. The config file can be generated as a copy of |
Yes, we'd have to discuss if we want to force/suggest a particular folder structure for the input files (what you called |
manim/manim/mobject/svg/code_mobject.py Lines 146 to 149 in 70c0d53
manim/manim/mobject/svg/svg_mobject.py Lines 49 to 54 in 70c0d53
Line 12 in 70c0d53
Line 28 in 70c0d53
|
Oh? Ok in that case we should document that somewhere in the mythical quickstart guide. In that case, I'm leaning toward making a quick-and-dirty |
I just want to clarify that manim will search for Before we implement And like the cfg file, we could make the |
I'd like to contribute to this if nobody is on it. So that it gives a first idea of what it could look like. |
@azarzadavila Please don't feel as if I'm restricting you, I'd just like to say that there will be a few changes to the code that will make it just a tiny bit easier to do this sort of stuff . You can still work on this in the meantime should you wish to. |
@Aathish04 |
@azarzadavila The PR I was talking about has been merged. You can implement |
@azarzadavila are you interested in implementing this? :) |
Hi everyone, A few thoughts:
If we are going to generate a bunch of directories, then this is how we would do it. |
I like the idea of keeping it short and to the point. Any more functionality sounds like we will hit a situation of diminishing returns. Especially because every new functionality will require new tests and more maintenance etc. |
This should be implemented after #1013 is merged |
I think that when this command is called it also ought to include on the first line of the generated script:
If the user doesn't want it, they can just delete the line once and it'll never be there again. Otherwise, they now can look back at the script later and tell what version they used (or others can tell). |
Can I get assigned? The 'project' subcommand will create a folder, a config file, and a main.py. I was thinking that in each manim project there has to be one python file that will import all scenes from within the project.
The 'scene' subcommand will create a new file with a new scene. this scene may automatically be imported in the main.py file as well as config.cfg file. I was also thinking of scene templates. where the user may give an additional argument naming the template that he wants to use or subcommand can prompt another input demanding the name of the template. if the user does not provide a name then the default template will be used for the new file generation.
if scene_name is not provided then filename will be used as the scene name |
We can also implement a |
Assigned you! ... although I'm not sure if this is actually a |
Thank you! ill reach out if I get stuck anywhere. |
Hey guys, The code for these commands is about 200 lines. |
I have opened up a pull request #1418 |
How about a sub command for example,
manim new project
, which will create a folder with some scripts assets folder and also a config file. This would be helpful for new users and we can make the users use uniform folder structure. This would surely be helpful while debugging and the users can keep the projects organised and not like I usually do.PS. I got the idea from chocolatey.
The text was updated successfully, but these errors were encountered: