-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Added project management commands #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
checks are failing for template scenes. |
I think I touched everything mentioned in the comments. let me know if I missed anything. thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are the last tidbits for making the CLI display help pages properly. Other than this, I think the subcommands work as intended. It may be worth adding documentation for these subcommands somewhere in the tutorials section, but I think this can be done in a future PR.
Co-authored-by: Jason Villanueva <a@jsonvillanueva.com>
Co-authored-by: Jason Villanueva <a@jsonvillanueva.com>
@kilacoda Sir it's been 4 days since you requested changes. could you possibly review them? thx |
Sorry, got caught up in some other stuff! Reviewing rn. |
Co-authored-by: Raghav Goel <kilacoda@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changelog / Overview
manim init
- quickly sets up default files for a manim project.manim new project
- lets the user set project settings. It also creates the project inside a new folder of name <project_name>manim new scene
- used to quickly insert new scenes into files. Iffile name
is not providedmain.py
is used as default.Added 3 commands in the "manim/cli/project/commands.py" file. Added 2 tests in "tests/test_commands.py"
Update:
directories have been restructured.
init command resides in manim/cli/init/command.py.
new command group resides in manim/cli/init/group.py
I also have changed the name of manim/cli/cfg/commands.py to manim/cli/cfg/group.py
Motivation
I want new users to quickly be able to create example scenes and edit those scenes to their liking. Some of my friends don't want to use manim only because they found it very hard
Explanation for Changes
New users of manim will be able to quickly set up projects and scenes from templates. The number of templates is very few at the moment but we can add more.
Commands
1 - manim init : this command quickly sets up default files for a manim project
2 - manim new project : this command lets the user set project settings. it also creates the project inside a new folder of name <project_name>. this command can be used in 3 different ways
3 - manim new scene : this command is used for inserting new scenes in files. if
file name
is not providedmain.py
is used as default. iffile name
is provided butfile name
does not exist. new file is created with namefile name
Testing Status
My PC specs:
Processor:............. core I 5 2400
RAM:..................... 8 GB ddr3 ram
GPU:..................... AMD rx 470
Operating System: Ubuntu 20.04
I have tested these commands extensively in ubuntu. I have not tested them in Windows. however i believe they will work fine
Further Comments
Checklist
Reviewer Checklist