Skip to content

Remove OpenCV and SceneFromVideo #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PgBiel opened this issue May 25, 2020 · 1 comment
Closed

Remove OpenCV and SceneFromVideo #85

PgBiel opened this issue May 25, 2020 · 1 comment
Labels
pr:deprecation Deprecation, or removal of deprecated code
Milestone
Initial Cleanup

Comments

@PgBiel
Copy link
Member

PgBiel commented May 25, 2020

opencv does not seem to be used anywhere other than in ScenefromVideo, which seems to be broken.
@PgBiel PgBiel added the pr:deprecation Deprecation, or removal of deprecated code label May 25, 2020
@PgBiel PgBiel added this to the Initial Cleanup milestone May 25, 2020
@leotrs
Copy link
Contributor

leotrs commented May 25, 2020

I vote we 100% scrap this file and opencv. Not only because it's broken but because this file is actually trying to use manim in a way that it's not intended. It seems like an awesome project to be honest, but I don't think it belongs inside manim itself. In the future, if anyone wants to work on this, I think it should live inside the ManimCommunity organization, but in a separate repo than manim itself.

@safinsingh safinsingh linked a pull request May 25, 2020 that will close this issue
Travis setup #86
Merged
@safinsingh safinsingh removed a link to a pull request May 25, 2020
Travis setup #86
Merged
@leotrs leotrs mentioned this issue May 27, 2020
Merged
@leotrs leotrs closed this as completed in 9f88d6e May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr:deprecation Deprecation, or removal of deprecated code
Projects
None yet
Milestone
Initial Cleanup
Development

No branches or pull requests
2 participants
@leotrs @PgBiel