Skip to content

Fixed single PEP8 style in cairo_renderer.py #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fixed single PEP8 style in cairo_renderer.py #1164

merged 1 commit into from
Mar 24, 2021

Conversation

jsonvillanueva
Copy link
Member

@jsonvillanueva jsonvillanueva commented Mar 24, 2021 •
edited
Loading

Overview / Explanation for Changes

#1019 being merged without conflicts against #1140 introduced some issues with CI. In the future, PRs should be updated with ManimCommunity/master prior to being merged (especially if it involves changes to the CI).

Acknowledgements

  • I have read the Contributing Guidelines
  • I have chosen a descriptive PR title (see top of PR template for examples)

Reviewer Checklist

  • Newly added functions/classes are either private or have a docstring
  • Newly added functions/classes have tests added and (optional) examples in the docs
  • Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
  • The PR title is descriptive enough

@jsonvillanueva jsonvillanueva added style pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! labels Mar 24, 2021
@jsonvillanueva jsonvillanueva requested a review from behackl March 24, 2021 09:31
behackl
behackl approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass and the pipeline is fixed.

@behackl behackl merged commit 63735d3 into ManimCommunity:master Mar 24, 2021
@behackl behackl added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label Apr 2, 2021
@jsonvillanueva jsonvillanueva deleted the flake8-remains branch May 4, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackl behackl behackl approved these changes

Assignees
No one assigned
Labels
maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review!
Projects
None yet
Milestone
Release v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jsonvillanueva @behackl