Skip to content

Create z_index to define layer for Mobjects #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2020
Merged

Create z_index to define layer for Mobjects #122

merged 6 commits into from
Jun 2, 2020

Conversation

TonyCrane
Copy link
Contributor

@PgBiel PgBiel added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Jun 2, 2020
@TonyCrane TonyCrane requested a review from eulertour June 2, 2020 01:07
@TonyCrane TonyCrane requested a review from PgBiel June 2, 2020 01:34
@PgBiel
Copy link
Member

PgBiel commented Jun 2, 2020

Regarding @eulertour's comment on getters: Imo, with the eventual usage of attrs, we should eventually transition into a general set (or edit, something like that) function for each class, allowing something like the example below, which allows for setting multiple attributes at the same time and is overall better:

mobj.set(x=5, y=6, z_index=50, ...)

The indiviudal set functions should be kept if they require more than one argument (although we could easily fix that by requiring a list on .set) or if they require any special work (in this case, the .set function would simply call the specific ones for you).

Anyway, this is better suited for its own issue. But I just thought about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using z-order to define layer for Mobjects
3 participants