-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Restructuring of Contribution Section #1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just restructuring for now. |
@@ -0,0 +1,103 @@ | |||
============== | |||
Adding Typings | |||
============== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add information about PEP-563, since we dropped py3.6 that should be something we can recommend.
See py3.7 changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this a PR for restructuring only I’ll do additions in a later PR which I’ll pull soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, SGTM
Changelog / Overview
Check the commits for the Changelog
Motivation
These changes make the contribution section of documentation more easier to read as it has been spilt up to the major topics.
Explanation for Changes
Developers can read this section more easier and won't have a problem navigating though the pages.
Documentation Reference
Testing Status
All Tests passes locally
Further Comments
Closes #1392 and closes #1466
Checklist
Reviewer Checklist