-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Make colour aliases IDE-friendly #2050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
While I wholeheartedly agree with this change, some other tried to fight it in the past for reasons I've now forgotten. |
I like this! I wish manim was less magical in other places as well ( |
Yeah 100% agree about |
Maybe I'm missing something but why does this still say |
I'm not an admin, it needs at least one person with commit privileges. That person takes the other reviewers into account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, I would like to improve our cluttered namespace and, for example, make people use colors from an enum. But well, this is not today, and the change here is a fine quality of life improvement (and it is not like we change the available colors very often).
I'll approve this, and if there are no concerns until later today, I'll merge it so that it is included in the upcoming release.
Thank you for your contribution!
This comment has been minimized.
This comment has been minimized.
Wait, ignore my last comment; thought we were on a different PR. This one is good to go! |
Fixes #2049
Overview: What does this pull request change?
Makes colour aliases like
BLUE
more tool friendly (e.g. in VSCode).Motivation and Explanation: Why and how do your changes improve the library?
See #2049
Links to added or changed documentation pages
Further Information and Comments
No idea why the grey order was A, B, C, E, D in the old code lol.
Reviewer Checklist