Internal Typing File for Type Aliases #2052
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new PR, don't mix stuff because it becomes hard while reviewing. Can you remove that change from this PR? |
naveen521kk
reviewed
Sep 17, 2021
3 tasks
Darylgolden
reviewed
Nov 28, 2021
| @@ -368,7 +369,7 @@ def get_run_time(self) -> float: | |||
|
|
|||
| def set_rate_func( | |||
| self, | |||
| rate_func: Callable[[float], float], | |||
| rate_func: "rate_function", | |||
There was a problem hiding this comment.
Should this be in quotes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Adds internal typing type aliases
Depreciates capture_mobject
We have a lot of complex and heavily repeated type names. This pull request proposes to merge them into importable type aliases with simple, but helpful, names.
I also deprecated capture_mobject as it came to my attention during this pull and proved unnecessary.
Reviewer Checklist