Skip to content

Added type hints to :mod:.utils.images #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2021
Merged

Added type hints to :mod:.utils.images #2194

merged 2 commits into from
Oct 17, 2021

Conversation

Davidy22
Copy link
Contributor

@Davidy22 Davidy22 commented Oct 14, 2021 •
edited
Loading

A lot easier than the other file I did

Part of the long series of PRs that will work towards #52.

behackl
behackl approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@Darylgolden Darylgolden added the documentation Improvements or additions to documentation label Oct 17, 2021
@Darylgolden Darylgolden merged commit 911ea4b into ManimCommunity:main Oct 17, 2021
@behackl behackl added maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements typehints For adding/discussing typehints and removed documentation Improvements or additions to documentation labels Nov 1, 2021
@behackl behackl changed the title Type hinting images.py Added type hints to :mod:.utils.images Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackl behackl behackl approved these changes

Assignees
No one assigned
Labels
maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements typehints For adding/discussing typehints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Davidy22 @behackl @Darylgolden