Skip to content

Removed instructions on using and installing Docker on README #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

Darylgolden
Copy link
Member

Overview: What does this pull request change?

Remove instructions on using and installing Docker on README, pointing users to the documentation instead.

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@naveen521kk
Copy link
Member

I think it's ok to have them, since, it's shown in https://hub.docker.com/r/manimcommunity/manim also.

@behackl behackl added the documentation Improvements or additions to documentation label Jan 6, 2022
@behackl
Copy link
Member

behackl commented Jan 6, 2022

I think it is fine to remove this. Even people on Dockerhub will find the corresponding information in our documentation.

@Darylgolden Darylgolden merged commit a781b30 into main Jan 7, 2022
@Darylgolden Darylgolden deleted the Darylgolden-patch-1 branch January 7, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants