Skip to content

Makes windows build faster, by using a prebuild Latex from TinyTex CI and avoid using Choco #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2020
Merged

Makes windows build faster, by using a prebuild Latex from TinyTex CI and avoid using Choco #277

merged 1 commit into from
Aug 15, 2020

Conversation

naveen521kk
Copy link
Member

@naveen521kk naveen521kk commented Aug 13, 2020 •
edited
Loading

In this PR;

  • Makes windows build faster, by using a prebuild Latex from TinyTex CI and avoid using Choco and download directly from the site as Choco is slower in actions.

@leotrs
Copy link
Contributor

leotrs commented Aug 13, 2020

This looks good to me, but I'm not a windows expert. I'll let others approve/request changes.

@leotrs leotrs changed the title Improve CI Makes windows build faster, by using a prebuild Latex from TinyTex CI and avoid using Choco Aug 13, 2020
@leotrs leotrs mentioned this pull request Aug 13, 2020
Closed
@PgBiel PgBiel added enhancement Additions and improvements in general pr:deprecation Deprecation, or removal of deprecated code labels Aug 13, 2020
@leotrs
Copy link
Contributor

leotrs commented Aug 15, 2020

I believe @XorUnison is on Windows? @XorUnison, if you are not available to review this, could you mention somebody else who is on windows? Please and thanks!

@XorUnison
Copy link
Collaborator

I believe @XorUnison is on Windows? @XorUnison, if you are not available to review this, could you mention somebody else who is on windows? Please and thanks!

Not sure who else is on windows, and I'd rather not bother with switching branches before I at least have the next commit for #210 done. But once that's dealt with I can have a look at this and test it.

@Aathish04
Copy link
Member

I believe @XorUnison is on Windows? @XorUnison, if you are not available to review this, could you mention somebody else who is on windows? Please and thanks!

Not sure who else is on windows, and I'd rather not bother with switching branches before I at least have the next commit for #210 done. But once that's dealt with I can have a look at this and test it.

I don't think you'll have to do much "testing", considering that this PR just changes the Github CI workflow for windows.

@XorUnison
Copy link
Collaborator

I don't think you'll have to do much "testing", considering that this PR just changes the Github CI workflow for windows.

It's purely focused on the building, eh... But I also have to say I don't quite know what's going on with the builds.

@naveen521kk
Copy link
Member Author

It does nothing but downloads some zip from the respective places then extracts it adds to path, installs what is not there.
Previous, it did used a batch script which had build (Takes about 2 min) now it just downloads the prebuild thing. Also, previously it used choco for ffmpeg and sox, now it directly downloads from respective sites and adds to path.

@leotrs leotrs merged commit 7b085b2 into ManimCommunity:master Aug 15, 2020
@naveen521kk naveen521kk deleted the latex-improve branch August 15, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leotrs leotrs leotrs approved these changes

@Aathish04 Aathish04 Aathish04 approved these changes

Assignees
No one assigned
Labels
enhancement Additions and improvements in general pr:deprecation Deprecation, or removal of deprecated code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@naveen521kk @leotrs @XorUnison @Aathish04 @PgBiel