-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add @
shorthand for CoordinateSystem
methods coords_to_point
(c2p
) and point_to_coords
(p2c
)
#3754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JasonGrace2282
merged 12 commits into
ManimCommunity:main
from
JasonGrace2282:@-shorthand
May 27, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e6284b1
Add shorthand for axes
JasonGrace2282 2b789f9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 30ea922
Add spacing
JasonGrace2282 fa1b08f
Convert CoordinateSystem example, and add to NumberLine
JasonGrace2282 1c8e440
Merge branch 'main' into @-shorthand
JasonGrace2282 4658ea1
Merge branch 'main' of github.com:JasonGrace2282/manim into @-shorthand
JasonGrace2282 ea7b323
Add doctest for NumberLine
JasonGrace2282 1fe0e86
Merge branch 'main' into @-shorthand
chopan050 bf6d2d9
Merge branch 'main' into @-shorthand
JasonGrace2282 068121f
Merge branch 'main' into @-shorthand
chopan050 c3fabde
Add test
JasonGrace2282 775aa7e
Fix typehint for c2p
JasonGrace2282 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Probably a test would be nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with removing the
*
is thatax @ (1, 0, 0)
then returns a 3x3 array, which I felt was kinda unintuitive.As for the test, I already have a doctest in
Axes
. Is another test really necessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of getting this merged, I went ahead and added a test for the behavior.