Add setup.py #45
Merged
Add setup.py #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
What exactly would this do though? How would this manim fork be run with that setup.py in place, and would that help in running the 3b1b manim and this community manim in parallel? |
leotrs
approved these changes
May 21, 2020
|
@XorUnison I think now we will be able to run this one by using |
|
I'm still not 100% about the manimcm name, but this can be merged and the name can be changed elsewhere... |
PgBiel
approved these changes
May 21, 2020
|
Merged. The next step here @eulertour is to add minimal tests for running manim using either |
WillSoltas
pushed a commit
to WillSoltas/manim
that referenced
this pull request
Mar 28, 2022
behackl
pushed a commit
that referenced
this pull request
Apr 5, 2022
…#2642) * Migrated file_ops.py and scene_file_writer.py from os.path to Pathlib (github issue #45) * Updated scene_file_writer.py to handle WindowsPaths * Updated scene_file_writer.py to handle WindowsPaths * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated file_ops.py to handle WindowsPaths * Updated scene_file_writer.py to handle WindowsPaths * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed Merge Conflict: Added Type Hints in file_ops.py * Changed test_file_ops to use Pathlib in accordance with file_ops.py usage * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Will Soltas <willsoltas@Wills-MacBook-Pro-2.local> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
setup.pywith anentry_pointsentry which replacesmanim.py, and removemanim.py.