Skip to content

Restore --save_pngs #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2020
Merged

Restore --save_pngs #47

merged 1 commit into from
May 21, 2020

Conversation

eulertour
Copy link
Member

Causes --save_pngs to save frames to /media/videos/<module name>/images/<scene name><frame number>.png. The paths here are a mess, but they can't really be improved on effectively until we make some progress on #12.

@leotrs
Copy link
Contributor

leotrs commented May 21, 2020

@Aathish04 perhaps leave your review? :)

Aathish04
Aathish04 approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@Aathish04 Aathish04 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, forgot to leave my review :)

I tested it with SquareToCircle from the basic example_scene and it works great!

@leotrs leotrs merged commit 20598bd into master May 21, 2020
@leotrs leotrs deleted the save-pngs branch May 21, 2020 12:30
@PgBiel PgBiel added the enhancement Additions and improvements in general label May 21, 2020
@eulertour
Copy link
Member Author

Oh come on! I was trying to do the same thing just as you committed. :)

https://imgur.com/gallery/4johHkJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leotrs leotrs leotrs approved these changes

@Aathish04 Aathish04 Aathish04 approved these changes

Assignees
No one assigned
Labels
enhancement Additions and improvements in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eulertour @leotrs @Aathish04 @PgBiel