Skip to content

Fix bug using z_index in VGroup #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix bug using z_index in VGroup #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions manim/mobject/mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,14 @@ def add(self, *mobjects):
if self in mobjects:
raise ValueError("Mobject cannot contain self")
self.submobjects = list_update(self.submobjects, mobjects)

# This will introduce another use_z_index flag
# There may be better solutions
# But for now, this is the easiest solution
if self.use_z_index:
self.submobjects = sorted(self.submobjects,
key=lambda m: m.z_index)

return self

def add_to_back(self, *mobjects):
Expand Down