Skip to content

Create Wait Animation #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Oct 28, 2020
Merged

Create Wait Animation #568

merged 24 commits into from
Oct 28, 2020

Conversation

eulertour
Copy link
Member

@eulertour eulertour commented Oct 19, 2020

Creates a Wait Animation which has the same effect as Scene.wait(). Also removes some of
the methods within Scene and the caching logic which is specific to waiting.

Depends on #562

Copy link
Member

@huguesdevimeux huguesdevimeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me.
Although there is no apparent reason it shouldn't work, did you try the caching mechanism with Wait with condition ?
Maybe a test for that with hashing is needed.

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the code look good to me. There are a few issues with the docstrings, please consider my suggestions.

@behackl behackl added pr:deprecation Deprecation, or removal of deprecated code enhancement Additions and improvements in general labels Oct 24, 2020
@leotrs
Copy link
Contributor

leotrs commented Oct 25, 2020

Let's add @behackl's suggestions and fix the conflict and then merge :)

@eulertour
Copy link
Member Author

This depends on #614 since it's currently based on the faulty logic for finding static mobjects.

@eulertour
Copy link
Member Author

@behackl This PR is ready when you are

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed 6c79273 -- good to go. 👍

@eulertour eulertour merged commit 6e87738 into master Oct 28, 2020
@eulertour eulertour deleted the wait-animation branch October 28, 2020 07:50
@cobordism
Copy link
Member

cobordism commented Nov 2, 2020

This PR broke the AddTextLetterByLetter animation (among others)

class lbl(Scene):
    def construct(self):
        t2 = Tex("this is test").shift(DOWN)
        self.play(AddTextLetterByLetter(t2[0]))
        #this works on the releases branch, but not on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additions and improvements in general pr:deprecation Deprecation, or removal of deprecated code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants