-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Create Wait Animation #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Naveen M K <naveen@syrusdark.website>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me.
Although there is no apparent reason it shouldn't work, did you try the caching mechanism with Wait
with condition ?
Maybe a test for that with hashing is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the code look good to me. There are a few issues with the docstrings, please consider my suggestions.
Let's add @behackl's suggestions and fix the conflict and then merge :) |
This depends on #614 since it's currently based on the faulty logic for finding static mobjects. |
@behackl This PR is ready when you are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I missed 6c79273 -- good to go. 👍
This PR broke the AddTextLetterByLetter animation (among others)
|
Creates a Wait Animation which has the same effect as Scene.wait(). Also removes some of
the methods within Scene and the caching logic which is specific to waiting.
Depends on #562