-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Switch to compressed numpy arrays for test control data #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What a hero. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
To have this live somewhere, here is the code I used for converting the import numpy as np
from pathlib import Path
p = Path(".")
control_files = [f for f in list(p.rglob("*")) if f.name[-4:] == ".npy"]
for file in control_files:
data = np.load(file)
np.savez_compressed(file.as_posix()[:-4], frame_data=data) |
Docs don't only fail to build here, but apparently on master as well. This is not related to the changes here, seems we forgot to remove some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many files to review 😂
How is this miracle even possible |
One method is called Huffman coding: |
List of Changes
As pointed out by @kolibril13 in #599, we should store the control data for the graphical unit tests in a compressed format. This PR switches
set_up_scene
and_load_data
to the compressed format, and changes all control files to the compressed format.The size of the
control_data
directory actually reduces from 132MB to 620KB (!!!).Testing Status
Tests pass locally -- and this should be easy to review: either the tests pass, or they don't. 🙃
Acknowledgement