Add ArcPolygon to geometry.py

[XorUnison]

Partial implementation of #210

Added ArcPolygon, to geometry.py

For test code and a result gif of the added feature, see #210, Test2.

[XorUnison]

So I attempted to put this after the first rendered example to demonstrate how to access the arcs:

    >>> print(reuleaux_triangle.arcs)
    '[ArcBetweenPoints, ArcBetweenPoints, ArcBetweenPoints]'

For some reason it actually renders fine in the docs, I think. Now for some inconceivable reason the other installation tests try to run this code... I'm open to suggestions on how to rewrite that part.

[leotrs]

Sorry I don't understand what you are asking 🤔

[XorUnison]

Sorry I don't understand what you are asking 🤔

I'm talking about this error message from the 9 CI tests:

925     >>> print(reuleaux_triangle.arcs)
UNEXPECTED EXCEPTION: NameError("name 'reuleaux_triangle' is not defined",)

Something about the doctest failing, despite the docs rendering fine. Clearly some part of the code gets it into it's head to try computing the part behind the >>>, which inevitably fails. I'll be looking into this tomorrow myself unless someone has a good suggestion in th meantime.

[behackl]

This is a feature: when using Python code and also specifying the expected output, then the corresponding lines are actually tested and checked within our pipeline.

The manim directive can handle this situation, but you will need to write the test a little bit differently: currently, your reuleaux_triangle is only accessible within the construct method of your class, it could not be accessed outside of it anyways. My suggestion would be to write it as follows:

.. manim:: ArcPolygonExample

    >>> arc_conf = {"stroke_width":0}
    >>> poly_conf = {"stroke_width":10,"stroke_color":BLUE,
    ...     "fill_opacity":1,"color": PURPLE}
    >>> a = [-1,0,0]
    >>> b = [1,0,0]
    >>> c = [0,np.sqrt(3),0]
    >>> arc0 = ArcBetweenPoints(a, b, radius=2, **arc_conf)
    >>> arc1 = ArcBetweenPoints(b, c, radius=2, **arc_conf)
    >>> arc2 = ArcBetweenPoints(c, a, radius=2, **arc_conf)
    >>> reuleaux_tri = ArcPolygon(arc0, arc1, arc2, **poly_conf)
    >>> reuleaux_tri.arcs
    [ArcBetweenPoints, ArcBetweenPoints, ArcBetweenPoints]
    >>> class ArcPolygonExample(Scene):
    ...     def construct(self):
    ...         self.play(FadeIn(reuleaux_tri))
    ...         self.wait(2)

The indentation of your manim-block is currently also messed up, the .. manim:: needs to start on the same level as the text before.

[behackl]

Thanks for you efforts! The code looks good in general to me -- however, I do have an issue with the current user interface.

[XorUnison]

I think this is about ready to get merged now, the docs build halfway decent and are very detailed, the 2 classes work nice too.
The docstrings will have to be edited again though once the Attributes issue is fixed.

[leotrs]

Only requesting minor stuff. Thanks for all the work.

[behackl]

I've added two commits (aa75e13, 3ab3555) with some minor changes in the formatting of the documentation; I am satisfied otherwise. Let me know if you are okay with this too, @XorUnison, then I'll merge it. (Or actually, I'll approve it now; if you are satisfied you can also just merge yourself.)

[XorUnison]

I've added two commits (aa75e13, 3ab3555)

Looks good to me so I'll go ahead and merge.