Skip to content

update pangocffi and pangocairocffi version #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

naveen521kk
Copy link
Member

@naveen521kk naveen521kk commented Dec 21, 2020

Motivation

Update pangocffi and pangocairocffi version. It allows setting DLL files using environment variable and this will be super helpful for windows users, as well as chocolatey package.

Overview / Explanation for Changes

Update:
pangocffi - 0.9.0
pangocairocffi - 0.5.0

Oneline Summary of Changes

- Update Pangocffi and Pangocairocffi (:pr:`871`)

Acknowledgements

Reviewer Checklist

  • Newly added functions/classes are either private or have a docstring
  • Newly added functions/classes have tests added and (optional) examples in the docs
  • Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
  • The oneline summary has been included in the wiki

@behackl
Copy link
Member

behackl commented Dec 21, 2020

If this actually allows to circumvent DLL hell, this is golden. I just triggered the pipeline again, hoping that the tests for macos-latest and python 3.8, as well as python 3.9 were just transient errors.

(I don't really see a reason for a segmentation fault not occurring for macos-latest + py3.7, if there were a problem with the latest version of the packages.)

@naveen521kk
Copy link
Member Author

Segmentation fault happens for all the CI runs of MacOS. Possibly something wrong with GitHub CI. Or someother things, no just this one.

If this actually allows to circumvent DLL hell, this is golden.

Partly helps, though not fully. It tries to load a DLL specified in variable, but deps of those DLL aren't bound to this fix though.

@leotrs
Copy link
Contributor

leotrs commented Dec 22, 2020

Tests still not passing :(

@naveen521kk
Copy link
Member Author

Closing in favour of #878

@naveen521kk naveen521kk deleted the update-pango branch December 23, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants