Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd.Series s.iloc[i] instead of s[i] #84

Merged
merged 1 commit into from
Mar 12, 2025
Merged

pd.Series s.iloc[i] instead of s[i] #84

merged 1 commit into from
Mar 12, 2025

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Feb 11, 2025 •
edited
Loading

@jalew188 is this still valid? or can the branch be removed?

@mschwoer mschwoer requested a review from jalew188 February 11, 2025 14:51
@mschwoer mschwoer marked this pull request as draft February 11, 2025 14:51
jalew188
jalew188 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is still requested

@mschwoer
Copy link
Contributor Author

is it used somewhere at all?
https://github.com/search?q=org%3AMannLabs%20translate_frag_df_to_plot_df&type=code

@jalew188 jalew188 marked this pull request as ready for review March 10, 2025 01:52
@jalew188
Copy link
Collaborator

This PR is ready to merge

@mschwoer mschwoer merged commit c8766b0 into development Mar 12, 2025
2 checks passed
@mschwoer mschwoer deleted the fix_pd_series_getitem branch March 12, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalew188 jalew188 jalew188 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @jalew188