Reduce mono dep #85
Merged
Reduce mono dep #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point. Microsoft is not going to support mono anymore, we shall switch into dotnet core in the future. However, it seems that RawFileReader assembles do not support apple silicon. |
|
See #80 |
jalew188
reviewed
Mar 10, 2025
| @@ -67,13 +67,15 @@ requires you to add the ppa to your trusted sources! | |||
| 5. Install pythonnet: `pip install pythonnet`. | |||
|
|
|||
|
|
|||
| NOTE, Homebrew installs the most recent version of mono, which may give rise to the following error on the M1 platform (which is due to an incompatible architecture for the files in the mono library): | |||
| NOTE, Homebrew installs the most recent version of mono, which may give rise to the following error on the silicon platform | |||
There was a problem hiding this comment.
The lastest RawFileReader (https://github.com/thermofisherlsms/RawFileReader/tree/main/Libs/NetCore/Net8) seems not support silicon platform.
There was a problem hiding this comment.
Did you try or do you have other resources? Should we create an issue at Thermo?
There was a problem hiding this comment.
We have reported this by email. @GeorgWa did they reply with a solution?
jalew188
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce the dependency on dotnet features, basically a better version of https://github.com/MannLabs/alpharaw/tree/tmp_hackathon