-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter unused fragments from peak_df #89
Conversation
Any redundencies with alphabase's remove unused fragments? |
The implementation adds functionality to remove unused peaks from MS data, which is useful for memory efficiency. The code is generally well-structured with good documentation. The main issues are:
|
Number of tokens: input_tokens=11268 output_tokens=2153 max_tokens=4096
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out on test file. Function is working and properly removing peaks from peak_df upon filtering spectrum_df.
Yes, potentially. This is something which could be improved in the future. |
Add remove_unused_peaks method to MSData_Base for efficient peak dataframe cleanup after spectrum filtering. Includes a numba-accelerated mask generator for high performance and supports both in-place and copy operations with full class inheritance preservation.
This PR was 1.87USD